With the fix you just mailed and changing all the ‘utf-8’ values to ‘iso-8859-1’, I get the right behaviour for Western Europe languages.
I suppose that we will have issues for Eastern Europe or Asian languages (if they attach some native text to documet an issue), but this is a low impact thing as we have workarounds.
However, in the long term, I think that we should be based in utf-8 to avoid artifacts. I suppose that when we think it is safe to move to utf-8, we should run some conversion script for the database.
Talking about artifacts, I found another one when testing your fix:
This is how to reproduce it. The initial status is a HelpSpot 1.03 install, with the outgoing e-mail fix pacthes.
Steps to reproduce:
- Copy the following text to a newly created ticket, putting your e-mail as the client’s.
- Make it public and send the note to the client.
The mail will appear OK (which means that your fix worked well now that the encoding is utf-8) but you will see that the uppercase O with the grave and the acute accent have the wrong characters in the bug history in the Workplace. The rest of the accented characters are OK.
Are you perhaps using a house-made conversion to UTF-8 for the database that is different from the one used for the outgoing mail? This bug is strange because normally either all characters work or all characters fail. Internationalization issues are normally not that selective…